frishi/threetwo-metadata-service
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🔧 Refactoring response

Browse Source
This commit is contained in:
Rishi Ghan
2024-06-03 17:23:12 -04:00
parent 30743a11cf
commit 7749f2db49
1 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
services/comicvine.service.ts
View File

@@ -492,7 +492,6 @@ export default class ComicVineService extends Service {
getIssuesForVolume: { getIssuesForVolume: {
rest: "POST /getIssuesForVolume", rest: "POST /getIssuesForVolume",
async handler(ctx: Context<{ volumeId: number }>) { async handler(ctx: Context<{ volumeId: number }>) {
const { volumeId } = ctx.params; const { volumeId } = ctx.params;
const issuesUrl = `${CV_BASE_URL}issues/?api_key=${process.env.COMICVINE_API_KEY}`; const issuesUrl = `${CV_BASE_URL}issues/?api_key=${process.env.COMICVINE_API_KEY}`;
@@ -504,23 +503,31 @@ export default class ComicVineService extends Service {
format: "json", format: "json",
field_list: field_list:
"id,name,image,issue_number,cover_date,description", "id,name,image,issue_number,cover_date,description",
limit: 100, // Adjust the limit as per your requirement limit: 100,
}, },
headers: { headers: {
Accept: "application/json", Accept: "application/json",
"User-Agent": "ThreeTwo", // It's good practice to define a User-Agent, especially when using APIs that might track request sources "User-Agent": "ThreeTwo",
}, },
}); });
// Map over the issues to ensure each issue has `description` and `image` fields // Map over the issues to include the year extracted from cover_date
const issuesWithDescriptionAndImage = const issuesWithDescriptionImageAndYear =
response.data.results.map((issue: any) => ({ response.data.results.map((issue: any) => {
...issue, const year = issue.cover_date
description: issue.description || "", // Ensure description field exists and default to empty string if not ? new Date(
image: issue.image || {}, // Ensure image field exists and default to empty object if not issue.cover_date
})); ).getFullYear()
: null; // Extract the year from cover_date
return {
...issue,
year: year,
description: issue.description || "",
image: issue.image || {},
};
});
return issuesWithDescriptionAndImage; return issuesWithDescriptionImageAndYear;
} catch (error) { } catch (error) {
this.logger.error( this.logger.error(
"Error fetching issues from ComicVine:", "Error fetching issues from ComicVine:",