🔧 Moved metadata panels to its own component

This commit is contained in:
Rishi Ghan
2022-05-24 14:03:07 -07:00
parent a156f07598
commit d50a5ada02
7 changed files with 175 additions and 348 deletions

View File

@@ -1,76 +0,0 @@
import React, { ReactElement } from "react";
import PropTypes from "prop-types";
import ellipsize from "ellipsize";
import Card from "../Carda";
import convert from "html-to-text";
export const ComicVineDetails = (comicVineData): ReactElement => {
const { data } = comicVineData;
return (
<div className="columns">
<div className="column">
<div className="comic-detail issue-metadata">
<dl>
<dd>
<div className="columns mt-2">
<div className="column is-3">
<Card
imageUrl={data.comicvine.image.small_url}
orientation={"vertical"}
hasDetails={false}
// cardContainerStyle={{ maxWidth: 200 }}
/>
</div>
<div className="column">
<dl>
<dt>
<h6 className="name has-text-weight-medium mb-1">
{ellipsize(data.name, 18)}
</h6>
</dt>
<dd>
<h6>{data.comicvine.name && data.comicvine.name}</h6>
<span className="is-size-7">
Is a part of{" "}
<span className="has-text-weight-semibold">
{data.comicvine.volumeInformation.name}
</span>
</span>
</dd>
<dd className="is-size-7 mt-2">
<div className="field is-grouped is-grouped-multiline">
<div className="control">
<span className="tags">
<span className="tag is-success is-light has-text-weight-semibold">
{data.comicvine.volumeInformation.start_year}
</span>
<span className="tag is-success is-light">
{data.comicvine.volumeInformation.count_of_issues}
</span>
</span>
</div>
<div className="control">
<div className="tags has-addons">
<span className="tag is-primary is-light">
ComicVine ID
</span>
<span className="tag is-info is-light">
{data.comicvine.id}
</span>
</div>
</div>
</div>
</dd>
</dl>
</div>
</div>
</dd>
</dl>
</div>
</div>
</div>
);
};
export default ComicVineDetails;

View File

@@ -1,22 +1,13 @@
import React, {
useState,
useEffect,
useMemo,
ReactElement,
useCallback,
} from "react";
import React, { useMemo, ReactElement, useCallback } from "react";
import PropTypes from "prop-types";
import { useNavigate } from "react-router-dom";
import T2Table from "../shared/T2Table";
import { isEmpty, isNil, isUndefined } from "lodash";
import RawFileDetails from "./RawFileDetails";
import ComicVineDetails from "./ComicVineDetails";
import MetadataPanel from "../shared/MetadataPanel";
import SearchBar from "./SearchBar";
import { useDispatch } from "react-redux";
import { searchIssue } from "../../actions/fileops.actions";
import ellipsize from "ellipsize";
import { determineCoverFile } from "../../shared/utils/metadata.utils";
interface IComicBookLibraryProps {
data: {
@@ -86,59 +77,7 @@ export const Library = (data: IComicBookLibraryProps): ReactElement => {
minWidth: 400,
accessor: "_source",
Cell: ({ value }) => {
const {
rawFileDetails,
sourcedMetadata: { comicvine, locg },
} = value;
const { issueName, url } = determineCoverFile({
comicvine,
locg,
rawFileDetails,
});
return (
<MetadataPanel props={value}>
<div></div>
{/* <dl>
<dt>
<h6 className="name has-text-weight-medium mb-1">
{rawFileDetails.name}
</h6>
</dt>
<dd className="is-size-7">
Is a part of{" "}
<span className="has-text-weight-semibold">
{inferredMetadata.issue.name}
</span>
</dd>
<dd className="is-size-7 mt-2">
<div className="field is-grouped is-grouped-multiline">
<div className="control">
<span className="tags">
<span className="tag is-success is-light has-text-weight-semibold">
{rawFileDetails.extension}
</span>
<span className="tag is-success is-light">
{prettyBytes(rawFileDetails.fileSize)}
</span>
</span>
</div>
<div className="control">
{inferredMetadata.issue.number && (
<div className="tags has-addons">
<span className="tag is-light">Issue #</span>
<span className="tag is-warning">
{inferredMetadata.issue.number}
</span>
</div>
)}
</div>
</div>
</dd>
</dl> */}
</MetadataPanel>
);
return <MetadataPanel data={value} />;
},
},
{

View File

@@ -1,92 +0,0 @@
import React, { ReactElement } from "react";
import PropTypes from "prop-types";
import { escapePoundSymbol } from "../../shared/utils/formatting.utils";
import prettyBytes from "pretty-bytes";
import ellipsize from "ellipsize";
import { LIBRARY_SERVICE_HOST } from "../../constants/endpoints";
import { Card } from "../Carda";
// raw file details
export const RawFileDetails = (rawFileData): ReactElement => {
const { rawFileDetails, inferredMetadata } = rawFileData.data;
const encodedFilePath = encodeURI(
`${LIBRARY_SERVICE_HOST}/${rawFileDetails.cover.filePath}`,
);
const filePath = escapePoundSymbol(encodedFilePath);
return (
<div className="columns">
<div className="column">
<div className="comic-detail issue-metadata">
<dl>
<dd>
<div className="columns mt-2">
<div className="column is-3">
<Card
imageUrl={filePath}
orientation={"vertical"}
hasDetails={false}
// cardContainerStyle={{ maxWidth: 200 }}
/>
</div>
<div className="column">
<dl>
<dt>
<h6 className="name has-text-weight-medium mb-1">
{rawFileDetails.name}
</h6>
</dt>
<dd className="is-size-7">
Is a part of{" "}
<span className="has-text-weight-semibold">
{inferredMetadata.issue.name}
</span>
</dd>
<dd className="is-size-7 mt-2">
<div className="field is-grouped is-grouped-multiline">
<div className="control">
<span className="tags">
<span className="tag is-success is-light has-text-weight-semibold">
{rawFileDetails.extension}
</span>
<span className="tag is-success is-light">
{prettyBytes(rawFileDetails.fileSize)}
</span>
</span>
</div>
<div className="control">
{inferredMetadata.issue.number && (
<div className="tags has-addons">
<span className="tag is-light">Issue #</span>
<span className="tag is-warning">
{inferredMetadata.issue.number}
</span>
</div>
)}
</div>
</div>
</dd>
</dl>
</div>
</div>
</dd>
</dl>
</div>
</div>
</div>
);
};
export default RawFileDetails;
RawFileDetails.propTypes = {
data: PropTypes.shape({
cover: PropTypes.shape({
filePath: PropTypes.string,
}),
name: PropTypes.string,
path: PropTypes.string,
fileSize: PropTypes.number,
extension: PropTypes.string,
}),
};