frishi/threetwo
1
0
Fork 0
Code Issues 9 Pull Requests 6 Actions Packages Projects Releases 2 Wiki Activity

Filenames with special characters in them fail library import #32

New Issue
Open
opened 2022-06-27 04:33:13 +00:00 by rishighan · 0 comments
rishighan commented 2022-06-27 04:33:13 +00:00 (Migrated from github.com)
Copy Link

Filenames with * in them, which is considered an illegal character in some OSes causes sharp's .toFile() method to fail with this trace:

Processing queue...
Unrar is located at: /usr/bin/unrar
p7zip is located at: /usr/bin/7za
Detected file type is .cbz, looking for comicinfo.xml...
Directory [ /userdata/covers/Sentinel Squad ONE - 005 (July 2006) ] was created.
Directory [ /userdata/covers/Sentinel Squad ONE - 001 (March 2006) ] was created.
Directory [ /userdata/covers/Sentinel Squad ONE - 004 (June 2006) ] was created.
Directory [ /userdata/covers/Sentinel - 004 (April 2006) ] was created.
Directory [ /userdata/covers/Sentinel - 005 (May 2006) ] was created.
Directory [ /userdata/covers/Sentinel - 003 (March 2006) ] was created.
Directory [ /userdata/covers/Secret Wars Secret Love - 001 (October 2015) ] was created.
Directory [ /userdata/covers/Sentinel Squad ONE - 003 (May 2006) ] was created.
Directory [ /userdata/covers/Secret Wars Journal - 005 (November 2015) ] was created.
Directory [ /userdata/covers/Secret Wars Journal - 004 (October 2015) ] was created.
Directory [ /userdata/covers/Secret Wars Journal - 002 (August 2015) ] was created.
Directory [ /userdata/covers/Secret Wars Journal - 001 (July 2015) ] was created.
Directory [ /userdata/covers/Sentinel Squad ONE - 002 (April 2006) ] was created.
Directory [ /userdata/covers/Secret Wars Journal - 003 (September 2015) ] was created.
Filenames with `*` in them, which is considered an illegal character in _some_ OSes causes sharp's `.toFile()` method to fail with this trace: ``` Processing queue... Unrar is located at: /usr/bin/unrar p7zip is located at: /usr/bin/7za Detected file type is .cbz, looking for comicinfo.xml... Directory [ /userdata/covers/Sentinel Squad ONE - 005 (July 2006) ] was created. Directory [ /userdata/covers/Sentinel Squad ONE - 001 (March 2006) ] was created. Directory [ /userdata/covers/Sentinel Squad ONE - 004 (June 2006) ] was created. Directory [ /userdata/covers/Sentinel - 004 (April 2006) ] was created. Directory [ /userdata/covers/Sentinel - 005 (May 2006) ] was created. Directory [ /userdata/covers/Sentinel - 003 (March 2006) ] was created. Directory [ /userdata/covers/Secret Wars Secret Love - 001 (October 2015) ] was created. Directory [ /userdata/covers/Sentinel Squad ONE - 003 (May 2006) ] was created. Directory [ /userdata/covers/Secret Wars Journal - 005 (November 2015) ] was created. Directory [ /userdata/covers/Secret Wars Journal - 004 (October 2015) ] was created. Directory [ /userdata/covers/Secret Wars Journal - 002 (August 2015) ] was created. Directory [ /userdata/covers/Secret Wars Journal - 001 (July 2015) ] was created. Directory [ /userdata/covers/Sentinel Squad ONE - 002 (April 2006) ] was created. Directory [ /userdata/covers/Secret Wars Journal - 003 (September 2015) ] was created. ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
Game-stopping bug
 bug
Something isn't working
 catch-all
Holding place for similar issues
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 fix
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 major
question
Further information is requested
 refactor
tech debt
testing-required
Fix issued, but tests are pending
 wontfix
This will not be worked on
No Label bug
Milestone
No items
No Milestone Dot Release
Projects
Clear projects
No project
Assignees
Clear assignees
frishi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: frishi/threetwo#32
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?