frishi/threetwo
1
0
Fork 0
Code Issues 9 Pull Requests 6 Actions Packages Projects Releases 2 Wiki Activity

Downloads from AirDC++ are incorrectly associated with the library entry of the comic that initiated the download #36

New Issue
Closed
opened 2022-07-04 08:31:15 +00:00 by rishighan · 1 comment
rishighan commented 2022-07-04 08:31:15 +00:00 (Migrated from github.com)
Copy Link

When the user downloads a file by going to the comic's detail page, via the Acquisition tab:

  1. The AirDC++ bundle gets associated with that comic's mongo _id
  2. If the download completes when the user is on some other comic's detail page its _id is passed to the endpoint that reconciles the AirDC++ bundle with the mongo entry incorrectly

The fix is to record the mongo _id of the comic during download initiation.

When the user downloads a file by going to the comic's detail page, via the `Acquisition` tab: 1. The `AirDC++` bundle gets associated with that comic's mongo `_id` 2. If the download completes when the user is on some other comic's detail page _its_ `_id` is passed to the endpoint that reconciles the `AirDC++` bundle with the mongo entry _incorrectly_ The fix is to record the mongo `_id` of the comic during download initiation.
rishighan commented 2022-07-28 16:14:19 +00:00 (Migrated from github.com)
Copy Link

A fix for this was pushed in f146dfdd0b
Currently testing the fix.

A fix for this was pushed in https://github.com/rishighan/threetwo/commit/f146dfdd0bd741eb9788e78e9a5a85252ffe8b57 Currently testing the fix.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
Game-stopping bug
 bug
Something isn't working
 catch-all
Holding place for similar issues
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 fix
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 major
question
Further information is requested
 refactor
tech debt
testing-required
Fix issued, but tests are pending
 wontfix
This will not be worked on
No Label bug testing-required
Milestone
No items
No Milestone Dot Release
Projects
Clear projects
No project
Assignees
Clear assignees
frishi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: frishi/threetwo#36
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?