frishi/threetwo
1
0
Fork 0
Code Issues 9 Pull Requests 6 Actions Packages Projects Releases 2 Wiki Activity

hostname for services is not inferred correctly in the Docker context #80

New Issue
Closed
opened 2023-05-16 16:20:08 +00:00 by rishighan · 0 comments
rishighan commented 2023-05-16 16:20:08 +00:00 (Migrated from github.com)
Copy Link

When running inside a Docker container, threetwo-ui is not reading the UNDERLYING_HOSTNAME correctly from the supplied docker-compose.env file. This causes a lot of API calls to fail since they fallback to localhost. This has to do with how Vite handles environment variables (https://stackoverflow.com/a/73534387/656708)

The possible solution is to prefix the environment variables with VITE_ wherever they are used in the UI

When running inside a Docker container, `threetwo-ui` is not reading the `UNDERLYING_HOSTNAME` correctly from the supplied `docker-compose.env` file. This causes a lot of API calls to fail since they fallback to `localhost`. This has to do with how Vite handles environment variables (https://stackoverflow.com/a/73534387/656708) The possible solution is to prefix the environment variables with `VITE_` wherever they are used in the UI
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
Game-stopping bug
 bug
Something isn't working
 catch-all
Holding place for similar issues
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 fix
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 major
question
Further information is requested
 refactor
tech debt
testing-required
Fix issued, but tests are pending
 wontfix
This will not be worked on
No Label bug
Milestone
No items
No Milestone Dot Release
Projects
Clear projects
No project
Assignees
Clear assignees
frishi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: frishi/threetwo#80
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?