frishi/threetwo-core-service
1
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

➕ MIMEtype check for comic book archives #3

Merged
rishighan merged 6 commits from mimetype-check into master 2023-03-24 03:59:30 +00:00
Conversation 1 Commits 6 Files Changed 10 +4201 -16348
rishighan commented 2023-03-17 16:44:56 +00:00 (Migrated from github.com)
Copy Link

This PR covers work to include a MIMEtype checker for compressed archives, so that the uncompression method doesn't rely on file extensions. File extensions can be incorrectly set either because of user error, or by the uncompression app.

MIMEtypes offer a more reliable way to correctly determine what format a comic book archive is.

This PR covers work to include a MIMEtype checker for compressed archives, so that the uncompression method doesn't rely on file extensions. File extensions can be [incorrectly set](https://github.com/rishighan/threetwo/issues/59#issuecomment-1470307124) either because of user error, or by the uncompression app. MIMEtypes offer a more reliable way to correctly determine what format a comic book archive is.
nstephenh (Migrated from github.com) reviewed 2023-03-17 16:44:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
nstephenh
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
frishi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: frishi/threetwo-core-service#3
Delete Branch "mimetype-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?