frishi/threetwo
1
0
Fork 0
Code Issues 9 Pull Requests 6 Actions Packages Projects Releases 2 Wiki Activity

AirDC++ Socket Status #58

Merged
rishighan merged 9 commits from service-statuses into master 2023-01-21 10:29:32 +00:00
Conversation 8 Commits 9 Files Changed 12 +376 -292
rishighan commented 2023-01-20 05:09:04 +00:00 (Migrated from github.com)
Copy Link

This PR covers work to achieve the following:

  1. A navbar icon that depicts in real-time, the connection to the AirDC++ web client via the airdcpp-websocket-api
  2. Surfacing session information for a connected status
  3. Surfacing error information for a disconnected status
This PR covers work to achieve the following: 1. A navbar icon that depicts in real-time, the connection to the AirDC++ web client via the `airdcpp-websocket-api` 2. Surfacing session information for a `connected` status 3. Surfacing error information for a `disconnected` status
maksis (Migrated from github.com) reviewed 2023-01-20 15:30:49 +00:00
src/client/actions/airdcpp.actions.tsx
@@ -32,190 +37,199 @@ function sleep(ms: number): Promise<NodeJS.Timeout> {
return new Promise((resolve) => setTimeout(resolve, ms));
maksis (Migrated from github.com) commented 2023-01-20 15:30:48 +00:00
Copy Link

Shouldn't you just call connect without any arguments since everything is set in the socket options?

Shouldn't you just call `connect` without any arguments since everything is set in the socket options?
nstephenh commented 2023-01-20 15:55:46 +00:00 (Migrated from github.com)
Copy Link

That's definitely react code :P
I don't see anything that seems wrong at a cursory glance. Lots of stuff I'm not familiar with, much of it project specific. Hopefully I can contribute more after looking at a few more of these/the project as a whole.

That's definitely react code :P I don't see anything that seems wrong at a cursory glance. Lots of stuff I'm not familiar with, much of it project specific. Hopefully I can contribute more after looking at a few more of these/the project as a whole.
👍 1
rishighan (Migrated from github.com) reviewed 2023-01-20 16:02:38 +00:00
src/client/actions/airdcpp.actions.tsx
@@ -32,190 +37,199 @@ function sleep(ms: number): Promise<NodeJS.Timeout> {
return new Promise((resolve) => setTimeout(resolve, ms));
rishighan (Migrated from github.com) commented 2023-01-20 16:02:37 +00:00
Copy Link

Yeah, I never tried testing it without params, after I implemented the change you suggested @maksis. I'll remove the params and push.

Yeah, I never tried testing it without params, after I implemented the change you suggested @maksis. I'll remove the params and push.
rishighan (Migrated from github.com) reviewed 2023-01-20 18:21:15 +00:00
src/client/actions/airdcpp.actions.tsx
@@ -32,190 +37,199 @@ function sleep(ms: number): Promise<NodeJS.Timeout> {
return new Promise((resolve) => setTimeout(resolve, ms));
rishighan (Migrated from github.com) commented 2023-01-20 18:21:15 +00:00
Copy Link

@maksis Addressed in 3102b489c8

@maksis Addressed in https://github.com/rishighan/threetwo/pull/58/commits/3102b489c8db55594a79ba84a9789dc9cd65493f
maksis (Migrated from github.com) reviewed 2023-01-20 19:04:06 +00:00
src/client/actions/airdcpp.actions.tsx
@@ -32,190 +37,199 @@ function sleep(ms: number): Promise<NodeJS.Timeout> {
return new Promise((resolve) => setTimeout(resolve, ms));
maksis (Migrated from github.com) commented 2023-01-20 19:04:06 +00:00
Copy Link

@maksis Addressed in 3102b48

But the same code is still everywhere...

> @maksis Addressed in [3102b48](https://github.com/rishighan/threetwo/commit/3102b489c8db55594a79ba84a9789dc9cd65493f) But the same code is still everywhere...
rishighan (Migrated from github.com) reviewed 2023-01-21 03:39:10 +00:00
src/client/actions/airdcpp.actions.tsx
@@ -32,190 +37,199 @@ function sleep(ms: number): Promise<NodeJS.Timeout> {
return new Promise((resolve) => setTimeout(resolve, ms));
rishighan (Migrated from github.com) commented 2023-01-21 03:39:10 +00:00
Copy Link

Grrrr... jk. Yes I'll update that

Grrrr... jk. Yes I'll update that
rishighan (Migrated from github.com) reviewed 2023-01-21 06:02:15 +00:00
src/client/actions/airdcpp.actions.tsx
@@ -32,190 +37,199 @@ function sleep(ms: number): Promise<NodeJS.Timeout> {
return new Promise((resolve) => setTimeout(resolve, ms));
rishighan (Migrated from github.com) commented 2023-01-21 06:02:15 +00:00
Copy Link

Aaaand done: 1d8dd3ca3e

Aaaand done: https://github.com/rishighan/threetwo/pull/58/commits/1d8dd3ca3e6d9b0b4a3cb4f6ba462a3de19daacf
maksis (Migrated from github.com) approved these changes 2023-01-21 07:18:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
rishighan
maksis
Labels
Clear labels
P0
Game-stopping bug
 bug
Something isn't working
 catch-all
Holding place for similar issues
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 fix
good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 major
question
Further information is requested
 refactor
tech debt
testing-required
Fix issued, but tests are pending
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
frishi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: frishi/threetwo#58
Delete Branch "service-statuses"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?